fix(red-team): correct Network Broker ChannelStats field names#199
Merged
Conversation
The ChannelStats schema was modeled from PRD prose, not the network-broker OpenAPI, so getChannelStats() typed accessors all returned undefined against the live API. Rename to the real fields (network_channels_server_domain, docker_registry, helm_chart, docker_image, online_channels, total_channels, client_version) and enrich Channel with added_by/last_online_at/ connected_clients_count/outdated_clients_count/features. Commit the network-broker spec so preflight validates these (allowlist the coincidental ErrorResponse name collision + live-only extra fields). Verified live. Closes #198
Merged
cdot65
added a commit
that referenced
this pull request
Jul 9, 2026
- feat(red-team): Network Broker channel sub-client (#187) - feat(red-team): supported-languages and target-profile error-log endpoints (#193) - feat(model-security): read-only models sub-client (#195) - fix(management): percent-encode TSG ID in customer-apps list path (#189) - fix(red-team): correct Network Broker ChannelStats field names (#199)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #198
What
getChannelStats()'s typed fields all returnedundefinedagainst the live API — theChannelStatsschema was built from the PRD's prose, not the network-broker OpenAPI. Found by running a read-only script against a live tenant.Fix
ChannelStatsfield names corrected to the real API:network_channels_server_domain,docker_registry,helm_chart,docker_image,online_channels,total_channels, plusclient_version.Channelenriched with live-observed fields:added_by,last_online_at,connected_clients_count,outdated_clients_count,features.specs/AIRS-Red-Teaming-Network-Broker.yamlso preflight validates these schemas going forward (this is why the bug slipped through originally — the spec wasn't in the repo).ErrorResponsename collision (the SDK'sErrorResponsemodels the AIRS scan error envelope, unrelated to the network-broker component of the same name) and the live-only fields the base spec omits.Verification
online/total: 1/2, real registry/chart/image,client_version: 1.4.0).format:check,lint,typecheck,preflight(0 unacknowledged; 102 acknowledged),docs:check, full Vitest (1351) all green locally.Patch — corrects a broken response contract; no API surface change.
🤖 Generated with Claude Code